Skip to content

Enabling spacebar in editable targets inside Gnav#6279

Open
bandana147 wants to merge 3 commits into
stagefrom
bc-placeholder
Open

Enabling spacebar in editable targets inside Gnav#6279
bandana147 wants to merge 3 commits into
stagefrom
bc-placeholder

Conversation

@bandana147

@bandana147 bandana147 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
  • Enabling spacebar in editable targets inside Gnav

Test URLs:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@bandana147
bandana147 requested a review from a team as a code owner July 13, 2026 04:51
@aem-code-sync

aem-code-sync Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@aem-code-sync
aem-code-sync Bot temporarily deployed to bc-placeholder July 13, 2026 15:36 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@spadmasa

Copy link
Copy Markdown

As its already confirmed working fine , adding the label.

@spadmasa spadmasa added the verified PR has been E2E tested by a reviewer label Jul 20, 2026

@colloyd colloyd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This css adjustment needs to be made for the background fix to work.

Comment thread libs/blocks/global-navigation/global-navigation.css Outdated
@milo-pr-merge

milo-pr-merge Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Skipped merging 6279: Enabling spacebar in editable targets inside Gnav due to failing or running checks

@colloyd colloyd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants